From 1290adcd9b7b699a0d2b06dece06e8dcc285024d Mon Sep 17 00:00:00 2001
From: Alivecow <mail@ta-lotz.de>
Date: Fri, 22 Nov 2024 21:34:01 +0100
Subject: [PATCH] fix: Fix error in calling of monic function

---
 src/tasks/tasks01/pfmath.rs |  6 +++---
 src/utils/poly.rs           | 25 +++++++++++++++----------
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/tasks/tasks01/pfmath.rs b/src/tasks/tasks01/pfmath.rs
index 9a9859c..b1e7516 100644
--- a/src/tasks/tasks01/pfmath.rs
+++ b/src/tasks/tasks01/pfmath.rs
@@ -82,11 +82,11 @@ pub fn gfpoly_sort(args: &Value) -> Result<Vec<Polynomial>> {
 }
 
 pub fn gfpoly_make_monic(args: &Value) -> Result<Polynomial> {
-    let mut poly_a = Polynomial::from_c_array(&args["A"].clone());
+    let poly_a = Polynomial::from_c_array(&args["A"].clone());
 
-    poly_a.monic();
+    let result = poly_a.monic();
 
-    Ok(poly_a)
+    Ok(result)
 }
 
 pub fn gfpoly_sqrt(args: &Value) -> Result<Polynomial> {
diff --git a/src/utils/poly.rs b/src/utils/poly.rs
index fa4b343..f56abf4 100644
--- a/src/utils/poly.rs
+++ b/src/utils/poly.rs
@@ -256,7 +256,7 @@ impl Polynomial {
         true
     }
 
-    pub fn monic(&mut self) {
+    pub fn monic(mut self) -> Self {
         let divident = self.polynomial.last().unwrap().clone();
 
         for fieldelement in &mut self.polynomial.iter_mut() {
@@ -274,6 +274,11 @@ impl Polynomial {
         {
             self.polynomial.pop();
         }
+
+        if self.is_empty() {
+            self = Polynomial::new(vec![FieldElement::new(vec![0; 16])]);
+        }
+        self
     }
 
     pub fn sqrt(self) -> Self {
@@ -1129,22 +1134,22 @@ mod tests {
             "1Ial5rAJGOucIdUe3zh5bw==",
             "gAAAAAAAAAAAAAAAAAAAAA=="
         ]);
-        let mut element1: Polynomial = Polynomial::from_c_array(&json1);
+        let element1: Polynomial = Polynomial::from_c_array(&json1);
 
-        element1.monic();
+        let result = element1.monic();
 
-        assert_eq!(json!(element1.to_c_array()), expected);
+        assert_eq!(json!(result.to_c_array()), expected);
     }
 
     #[test]
     fn test_poly_monic_poly_zero() {
         let json1 = json!(["AAAAAAAAAAAAAAAAAAAAAA=="]);
         let expected = json!(["AAAAAAAAAAAAAAAAAAAAAA=="]);
-        let mut element1: Polynomial = Polynomial::from_c_array(&json1);
+        let element1: Polynomial = Polynomial::from_c_array(&json1);
 
-        element1.monic();
+        let result = element1.monic();
 
-        assert_eq!(json!(element1.to_c_array()), expected);
+        assert_eq!(json!(result.to_c_array()), expected);
     }
 
     #[test]
@@ -1156,11 +1161,11 @@ mod tests {
             "AAAAAAAAAAAAAAAAAAAAAA=="
         ]);
         let expected = json!(["AAAAAAAAAAAAAAAAAAAAAA=="]);
-        let mut element1: Polynomial = Polynomial::from_c_array(&json1);
+        let element1: Polynomial = Polynomial::from_c_array(&json1);
 
-        element1.monic();
+        let result = element1.monic();
 
-        assert_eq!(json!(element1.to_c_array()), expected);
+        assert_eq!(json!(result.to_c_array()), expected);
     }
 
     #[test]