From 295ed98c1e3805756370df8b6bc919b80d82bfd6 Mon Sep 17 00:00:00 2001
From: Alivecow <mail@ta-lotz.de>
Date: Sat, 16 Nov 2024 14:59:31 +0100
Subject: [PATCH] fix: Add further handling to leading zero blocks in add and
 powmod

---
 src/utils/field.rs | 30 +++++++++++++++++++++++++-----
 1 file changed, 25 insertions(+), 5 deletions(-)

diff --git a/src/utils/field.rs b/src/utils/field.rs
index 37502f6..02eac1e 100644
--- a/src/utils/field.rs
+++ b/src/utils/field.rs
@@ -81,7 +81,7 @@ impl Polynomial {
 
         if exponent == 0 {
             Polynomial::new(vec![FieldElement::new(
-                polynomial_2_block(vec![1], "gcm").unwrap(),
+                polynomial_2_block(vec![0], "gcm").unwrap(),
             )])
             .div(&modulus)
             .1;
@@ -102,6 +102,23 @@ impl Polynomial {
             //eprintln!("After mod: {:?}", self);
             exponent >>= 1;
         }
+
+        while !result.polynomial.is_empty()
+            && result
+                .polynomial
+                .last()
+                .unwrap()
+                .as_ref()
+                .iter()
+                .all(|&x| x == 0)
+        {
+            result.polynomial.pop();
+        }
+
+        if result.is_empty() {
+            result = Polynomial::new(vec![FieldElement::new(vec![0; 16])]);
+        }
+
         result
     }
 
@@ -246,10 +263,13 @@ impl Add for Polynomial {
             }
         }
 
-        for i in (0..polynomial.len() - 1).rev() {
-            if polynomial[i].is_zero() {
-                polynomial.pop();
-            }
+        while !polynomial.is_empty() && polynomial.last().unwrap().as_ref().iter().all(|&x| x == 0)
+        {
+            polynomial.pop();
+        }
+
+        if polynomial.is_empty() {
+            return Polynomial::new(vec![FieldElement::new(vec![0; 16])]);
         }
 
         Polynomial::new(polynomial)