From 8064dcb9e805c395235c261a3c8cd3bd5ccc5621 Mon Sep 17 00:00:00 2001
From: Alivecow <mail@ta-lotz.de>
Date: Sat, 30 Nov 2024 16:07:39 +0100
Subject: [PATCH] fix: Fix incorrect dic output. Remainder could be zero.

---
 src/utils/poly.rs | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/utils/poly.rs b/src/utils/poly.rs
index c294ccb..7f9cbe6 100644
--- a/src/utils/poly.rs
+++ b/src/utils/poly.rs
@@ -140,7 +140,7 @@ impl Polynomial {
         //eprintln!("result in powmod after reduction: {:02X?}", result);
 
         if result.is_empty() {
-            result = Polynomial::new(vec![FieldElement::new(vec![0; 16])]);
+            result = Polynomial::zero();
         }
 
         result
@@ -192,7 +192,7 @@ impl Polynomial {
         }
 
         if result.is_empty() {
-            result = Polynomial::new(vec![FieldElement::new(vec![0; 16])]);
+            result = Polynomial::zero();
         }
 
         result
@@ -241,7 +241,7 @@ impl Polynomial {
         }
 
         if result.is_empty() {
-            result = Polynomial::new(vec![FieldElement::new(vec![0; 16])]);
+            result = Polynomial::zero();
         }
 
         result
@@ -278,20 +278,16 @@ impl Polynomial {
                 remainder.polynomial[pos] = a + &(divisor_coeff * c);
             }
 
-            // Remove trailing zeros
-            while !remainder.polynomial.is_empty()
-                && remainder
-                    .polynomial
-                    .last()
-                    .unwrap()
-                    .as_ref()
-                    .iter()
-                    .all(|&x| x == 0)
+            while !remainder.polynomial.is_empty() && remainder.polynomial.last().unwrap().is_zero()
             {
                 remainder.polynomial.pop();
             }
         }
 
+        if remainder.is_empty() {
+            remainder = Polynomial::zero();
+        }
+
         (Polynomial::new(quotient_coeffs), remainder)
     }